Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc/1.6.0 #1378

Merged
merged 47 commits into from
Mar 24, 2020
Merged

rc/1.6.0 #1378

merged 47 commits into from
Mar 24, 2020

Conversation

NileGraddis
Copy link
Contributor

This is the release candidate for release 1.6.0, tentatively slated for release on March 6 2020. All new features should target this branch (bugfixes ought to instead target master).

Please see the confluence guide for more information on the release process.

jsiegle and others added 15 commits December 2, 2019 10:52
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi ininformative uninformative",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
Previously BehaviorDataLimsApi would raise an exception if no container id
was returned from lims id for given ophys id. This has been changed at
allenskd/internal/api/behavior_data_lims_api.py 105 - 108. Now the query will
return None for the container id if the query results in an empty list return.
Resolves: #1354
@codecov-io
Copy link

codecov-io commented Feb 22, 2020

Codecov Report

Merging #1378 into master will increase coverage by 0.11%.
The diff coverage is 51.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1378      +/-   ##
==========================================
+ Coverage   34.59%   34.71%   +0.11%     
==========================================
  Files         342      342              
  Lines       33243    33253      +10     
==========================================
+ Hits        11501    11543      +42     
+ Misses      21742    21710      -32
Impacted Files Coverage Δ
allensdk/core/brain_observatory_nwb_data_set.py 22.3% <ø> (ø) ⬆️
allensdk/internal/api/behavior_data_lims_api.py 52.84% <0%> (-1.55%) ⬇️
...dk/brain_observatory/behavior/trials_processing.py 24.46% <0%> (-0.07%) ⬇️
...k/brain_observatory/behavior/rewards_processing.py 100% <100%> (ø) ⬆️
allensdk/internal/brain_observatory/time_sync.py 24.84% <100%> (+24.84%) ⬆️
allensdk/__init__.py 68.96% <100%> (ø) ⬆️
...brain_observatory/ecephys/copy_utility/__main__.py 63.52% <100%> (+0.43%) ⬆️
...dk/brain_observatory/ecephys/write_nwb/__main__.py 67.59% <25%> (+0.23%) ⬆️
allensdk/internal/api/behavior_ophys_api.py 28.93% <25%> (+0.21%) ⬆️
...ephys/stimulus_analysis/receptive_field_mapping.py 89.01% <50%> (-0.44%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba72143...57b67b2. Read the comment docs.

Fixed bug requiring additional IDs for BehaviorDataLimsApi
Add ecephys optotagging tutorial
Previously the BehaviorOphysLimsApi did not compute
monitor delay, but added a default value of 0.351.
This updates the default to 0.215, which is the
average of monitor delay for a large number of recent
datasets.

Additionally use the OphysTimeAligner methods to
compute the display lag, which is used in the
OphysTimeSync job to produce corrected timestamps
in the LIMS pipeline.
Previously the BehaviorOphysLimsApi did not compute
monitor delay, but added a default value of 0.351.
This updates the default to 0.215, which is the
average of monitor delay for a large number of recent
datasets.

Additionally use the OphysTimeAligner methods to
compute the display lag, which is used in the
OphysTimeSync job to produce corrected timestamps
in the LIMS pipeline.
kschelonka and others added 20 commits March 2, 2020 13:45
WIP: Compute display lag in BehaviorOphysLimsApi
Fixes a bug where auto-rewarded trials were not properly
attributed in the rewards property of a visual behavior
Session. Update tests to cover multiple values of 'auto_reward'.
…undant-trial-col

GH 771: Remove redundant 'sham_change' column from trials
…d-key

GH-712: Fix auto-rewarded in rewards results
If there are more "stimulus transitions" than "photodiode events",
truncate the "stimulus transitions" to the number of
"photodiode events". This is similar to what is done with
ophys timestamps data in this module. Update test coverage
to handle this case.

Update logging to show the min and max delay, to help
with debugging in the case of unusual/default values.
Avoids memory errors from trying to load in large
data sets and generate a checksum all at once.
…large-data

Do checksums for data files in chunks
NWB advises to include this keyword in the NWB file write. This keyword caches the extension in the NWB file so it's easier for others to read data. No need to import ecephys.nwb.
No longer needed to include in the NWB file attributes. Confirmed with Ben Dichter this is not required anymore.
Added cache_spec==True keyword to lfp_writer.write call
Accepting arbitrary kwargs led to confusion for scientists
accidentally passing incorrect keywords. This PR removes
the ability to pass arbitrary kwargs to public Project cache
constructors, to reduce the possibility of silent errors.
…havior_ndx

add version to AIBS_ophys_behavior
Removed help from NWB file attributes
GH 1357: Project caches should not accept arbitrary kwargs
…tlib_hist_arg

updating to keyword density from normed for matplotlib.pyplot.hist
@djkapner
Copy link
Contributor

djkapner commented Mar 23, 2020

before merge

  • update version in __init__.py
  • update what's new in index.rst
  • update the CHANGELOG.md
  • make sure github CI passes
  • make sure the bamboo branch build passes. 

merge!

  • merge rc/x.y.z -> master

after merge

@djkapner djkapner merged commit 924757e into master Mar 24, 2020
@djkapner djkapner deleted the rc/1.6.0 branch October 9, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants