-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rc/1.6.0 #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
=== Do not change lines below === { "chain": [], "cmd": "git-sedi ininformative uninformative", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
Previously BehaviorDataLimsApi would raise an exception if no container id was returned from lims id for given ophys id. This has been changed at allenskd/internal/api/behavior_data_lims_api.py 105 - 108. Now the query will return None for the container id if the query results in an empty list return. Resolves: #1354
NileGraddis
requested review from
kschelonka,
njmei and
sgratiy
as code owners
February 22, 2020 01:29
Codecov Report
@@ Coverage Diff @@
## master #1378 +/- ##
==========================================
+ Coverage 34.59% 34.71% +0.11%
==========================================
Files 342 342
Lines 33243 33253 +10
==========================================
+ Hits 11501 11543 +42
+ Misses 21742 21710 -32
Continue to review full report at Codecov.
|
Fixed bug requiring additional IDs for BehaviorDataLimsApi
minor typo fix
Add ecephys optotagging tutorial
Previously the BehaviorOphysLimsApi did not compute monitor delay, but added a default value of 0.351. This updates the default to 0.215, which is the average of monitor delay for a large number of recent datasets. Additionally use the OphysTimeAligner methods to compute the display lag, which is used in the OphysTimeSync job to produce corrected timestamps in the LIMS pipeline.
Previously the BehaviorOphysLimsApi did not compute monitor delay, but added a default value of 0.351. This updates the default to 0.215, which is the average of monitor delay for a large number of recent datasets. Additionally use the OphysTimeAligner methods to compute the display lag, which is used in the OphysTimeSync job to produce corrected timestamps in the LIMS pipeline.
version and cache spec
WIP: Compute display lag in BehaviorOphysLimsApi
Fixes a bug where auto-rewarded trials were not properly attributed in the rewards property of a visual behavior Session. Update tests to cover multiple values of 'auto_reward'.
…undant-trial-col GH 771: Remove redundant 'sham_change' column from trials
…d-key GH-712: Fix auto-rewarded in rewards results
If there are more "stimulus transitions" than "photodiode events", truncate the "stimulus transitions" to the number of "photodiode events". This is similar to what is done with ophys timestamps data in this module. Update test coverage to handle this case. Update logging to show the min and max delay, to help with debugging in the case of unusual/default values.
This reverts commit fbadaba.
Avoids memory errors from trying to load in large data sets and generate a checksum all at once.
…large-data Do checksums for data files in chunks
Add alias for _get_rf
NWB advises to include this keyword in the NWB file write. This keyword caches the extension in the NWB file so it's easier for others to read data. No need to import ecephys.nwb.
No longer needed to include in the NWB file attributes. Confirmed with Ben Dichter this is not required anymore.
Added cache_spec==True keyword to lfp_writer.write call
Accepting arbitrary kwargs led to confusion for scientists accidentally passing incorrect keywords. This PR removes the ability to pass arbitrary kwargs to public Project cache constructors, to reduce the possibility of silent errors.
…havior_ndx add version to AIBS_ophys_behavior
Removed help from NWB file attributes
GH 1357: Project caches should not accept arbitrary kwargs
…tlib_hist_arg updating to keyword density from normed for matplotlib.pyplot.hist
before merge
merge!
after merge
|
kschelonka
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release candidate for release 1.6.0, tentatively slated for release on March 6 2020. All new features should target this branch (bugfixes ought to instead target master).
Please see the confluence guide for more information on the release process.